On 11/19/18 10:10 PM, Thomas Huth wrote:
On 2018-11-19 13:25, Cornelia Huck wrote:
On Mon, 19 Nov 2018 20:08:19 +0800
Mao Zhongyi <maozhon...@cmss.chinamobile.com> wrote:
Most of the SysBusDeviceClass variables are named sbc,
and sbdc here is a bit weird, so changing sbdc to keep
it consistent with others might look good.
A quick git grep also gives sbd and k as variable names, and it is used
in a total of two lines which have not been touched since 2013, so...
meh. If others like the change, I'm not opposed to merging, though.
I think I agree with Cornelia, just changing the variable name because
it's named differently in a couple of other places is just unnecessary
code churn, which makes "git blame" output harder to read later. I'd
suggest to drop this patch, too.
Ok, I got it. :)
Thanks,
Mao
Thomas
