On Thu, Nov 22, 2018 at 17:09:22 +0000, Alex Bennée wrote: > > Emilio G. Cota <c...@braap.org> writes: > > > This will be used by plugin code to flush the code cache as well > > as doing other bookkeeping in a safe work environment. > > This seems a little excessive given the plugin code could just call > tb_flush() directly. Wouldn't calling tb_flush after scheduling the > plugin_destroy be enough? > > If there is a race condition here maybe we could build some sort of > awareness into tb_flush as to the current run state. But having two > entry points to this rather fundamental action seems likely to either be > misused or misunderstood.
We have to make sure that no callback left in the generated code is called once a plugin has been uninstalled. To me, using the same safe work window to both flush the TB and uninstall the plugin seems the simplest way to do this. Thanks, Emilio