On 26/11/18 21:04, miny...@acm.org wrote:
> From: Corey Minyard <cminy...@mvista.com>
>
> It can't fail, and now that it returns a uint8_t a 0xff mask
> is unnecessary.
>
> Signed-off-by: Corey Minyard <cminy...@mvista.com>
> Suggested-by: Peter Maydell <peter.mayd...@linaro.org>
> ---
> hw/arm/stellaris.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/arm/stellaris.c b/hw/arm/stellaris.c
> index 6c69ce79b2..638b649911 100644
> --- a/hw/arm/stellaris.c
> +++ b/hw/arm/stellaris.c
> @@ -811,7 +811,7 @@ static void stellaris_i2c_write(void *opaque, hwaddr
> offset,
> /* TODO: Handle errors. */
> if (s->msa & 1) {
> /* Recv */
> - s->mdr = i2c_recv(s->bus) & 0xff;
> + s->mdr = i2c_recv(s->bus);
> } else {
> /* Send */
> i2c_send(s->bus, s->mdr);
>
This could be squashed in the previous patch.
Reviewed-by: Philippe Mathieu-Daudé <phi...@redhat.com>
Tested-by: Philippe Mathieu-Daudé <phi...@redhat.com>
