On Mon, Nov 26, 2018 at 11:30:25 -0800, Richard Henderson wrote: > On 11/26/18 11:07 AM, Emilio G. Cota wrote: > > The main reason why I added the qemu_plugin_insn_append calls > > was to avoid reading the instructions twice from guest memory, > > because I was worried that doing so might somehow alter the > > guest's execution, e.g. what if we read a cross-page instruction, > > and both pages mapped to the same TLB entry? We'd end up having > > more TLB misses because instrumentation was enabled. > > A better solution for this, I think is to change direct calls from > > cpu_ldl_code(env, pc); > to > translator_ldl_code(dc_base, env, pc); > > instead of passing around a new argument separate from DisasContextBase?
I think this + diff'ing pc_next should work to figure out the contents and size of each instruction. I'll do it this way in v2. Thanks, Emilio