On Tue, Nov 27, 2018 at 02:52:35PM +0800, Wei Wang wrote: > On 11/27/2018 02:06 PM, Peter Xu wrote: > > On Thu, Nov 15, 2018 at 06:08:00PM +0800, Wei Wang wrote: > > Again, is it possible to resize during migration? > > > > So I think the check is fine, but uncertain about the comment. > > Yes, resize would not happen with the current implementation. > But heard it could just be a temporal implementation. Probably > we could improve the comment like this: > > " > Though the implementation might not support ram resize currently, > this could happen in theory with future updates. So the check here > handles the case that RAMBLOCK is resized after the free page hint is > reported. > "
I'm not familiar with that part, but this seems ok to me. Thanks, -- Peter Xu
