I like better the patch that Thomas linked to. I think Philippe should have included Thomas' patch, rather than creating new, overlapping, patches. Confusion about straitforward things! Aleksandar
________________________________________ From: Thomas Huth <th...@redhat.com> Sent: Tuesday, November 27, 2018 10:49:27 AM To: Philippe Mathieu-Daudé; Aleksandar Markovic; Stefan Markovic Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org Subject: Re: [PATCH for-3.1 07/25] MAINTAINERS: Add a missing entry for the Fulong 2E machine On 2018-11-25 21:49, Philippe Mathieu-Daudé wrote: > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAINERS > index aa17e9bbd3..81a22b2ccf 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -864,6 +864,7 @@ R: Stefan Markovic <smarko...@wavecomp.com> > S: Odd Fixes > F: hw/mips/mips_fulong2e.c > F: hw/isa/vt82c686.c > +F: hw/pci-host/bonito.c > > F: include/hw/isa/vt82c686.h Please remove the empty line between bonito.c and vt82c686.h - or we could use my patch here from last Thursday instead: https://lists.gnu.org/archive/html/qemu-devel/2018-11/msg04526.html Thomas
