On Thu, Nov 29, 2018 at 12:57:16 +0300, Roman Bolshakov wrote: > Hi Emilio, > > I think there's an issue with "\s" character class, it's not recognized > by macOS sed and I'm getting incorrect lines in > qemu-plugins-ld64.symbols: > _ qemu_xxx > _ qemu_xyz > > After I replaced "\s" with "[[:space:]]", linking proceeds further
Nice, thanks. Will update. > , but doesn't succeed because of an unresolved reference for qemu-system cris, > lm32, m68k, microblaze, microblazeel, moxie, nios2, or1k, riscv32, > riscv64, sparc, unicore32, tricore, xtensa, xtensaeb: > > Undefined symbols for architecture x86_64: > "_pci_register_bar", referenced from: > _plugin_chan_realize in plugin-chan.o > > It probably has nothing to do with macOS per-se and shouldn't link on > Linux as well. If I disable the aforementioned targets the build > succeeds and I can see the symbols from qemu-plugins-ld64.symbols in > compiled qemu-system binaries. Yes, that's because plugin-chan should only be built if the guest has PCI support. Will fix. Thanks, Emilio