On 03/09/11 14:04, Michael Roth wrote: > On 03/09/2011 04:33 AM, Jes Sorensen wrote: >>> diff --git a/qemu-ioh.c b/qemu-ioh.c >>> index cc71470..5c3f94c 100644 >>> --- a/qemu-ioh.c >>> +++ b/qemu-ioh.c >>> @@ -113,3 +117,94 @@ void qemu_process_fd_handlers2(void >>> *ioh_record_list, const fd_set *rfds, >>> } >>> } >>> } >>> + >>> +#ifndef _WIN32 >>> +void iothread_event_increment(int *io_thread_fd) >> >> Please move these functions into posix/w32 specific files so we don't >> get anymore ugly #ifdefs. It would be good if we could use a wrapper >> struct as well to hide the different data types so we don't need #ifdefs >> in the calling code as well. > > Yup, meant to add this to the TODO. I may end up sending these general > tools changes out in a separate patchset since they seem to be in > conflict with quite of few patches floating around the list. Either way > I'll make sure to get these cleaned up and tested a bit a more.
Sounds great! Since they are not directly part of virtagent you should be able to push them in soon too. Cheers, Jes
