On Thu, Dec 6, 2018 at 4:38 AM Marc-André Lureau <
marcandre.lur...@redhat.com> wrote:
> COLO uses a worker context (iothread) to drive the chardev. All
> backends are not able to switch the context, let's report an error in
> this case.
>
> Signed-off-by: Marc-André Lureau <marcandre.lur...@redhat.com>
>
Reviewed-by: Zhang Chen <zhangc...@gmail.com>
> ---
> net/colo-compare.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/net/colo-compare.c b/net/colo-compare.c
> index a39191d522..9156ab3349 100644
> --- a/net/colo-compare.c
> +++ b/net/colo-compare.c
> @@ -957,6 +957,12 @@ static int find_and_check_chardev(Chardev **chr,
> return 1;
> }
>
> + if (!qemu_chr_has_feature(*chr, QEMU_CHAR_FEATURE_GCONTEXT)) {
> + error_setg(errp, "chardev \"%s\" cannot switch context",
> + chr_name);
> + return 1;
> + }
> +
> return 0;
> }
>
> --
> 2.20.0.rc1
>
>
