On Mon, 10 Dec 2018 19:28:10 +0100 Paolo Bonzini <pbonz...@redhat.com> wrote:
> It is not used outside hw/vfio/common.c, so it does not need to > be extern. > > Cc: Alex Williamson <alex.william...@redhat.com> > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > --- > hw/vfio/common.c | 2 +- > include/hw/vfio/vfio-common.h | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) Acked-by: Alex Williamson <alex.william...@redhat.com> > diff --git a/hw/vfio/common.c b/hw/vfio/common.c > index 7c185e5a2e..7aa804ea0b 100644 > --- a/hw/vfio/common.c > +++ b/hw/vfio/common.c > @@ -39,7 +39,7 @@ > > struct vfio_group_head vfio_group_list = > QLIST_HEAD_INITIALIZER(vfio_group_list); > -struct vfio_as_head vfio_address_spaces = > +static QLIST_HEAD(, VFIOAddressSpace) vfio_address_spaces = > QLIST_HEAD_INITIALIZER(vfio_address_spaces); > > #ifdef CONFIG_KVM > diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfio-common.h > index 1b434d02f6..127ca47815 100644 > --- a/include/hw/vfio/vfio-common.h > +++ b/include/hw/vfio/vfio-common.h > @@ -181,7 +181,6 @@ int vfio_get_device(VFIOGroup *group, const char *name, > > extern const MemoryRegionOps vfio_region_ops; > extern QLIST_HEAD(vfio_group_head, VFIOGroup) vfio_group_list; > -extern QLIST_HEAD(vfio_as_head, VFIOAddressSpace) vfio_address_spaces; > > #ifdef CONFIG_LINUX > int vfio_get_region_info(VFIODevice *vbasedev, int index,