On Tue, Dec 11, 2018 at 06:56:39PM +0530, P J P wrote: > From: Prasad J Pandit <p...@fedoraproject.org> > > Define skeleton 'uar_read' routine. Avoid NULL dereference. > > Reported-by: Li Qiang <liq...@163.com> > Signed-off-by: Prasad J Pandit <p...@fedoraproject.org> > --- > hw/rdma/vmw/pvrdma_main.c | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c > index ca5fa8d981..a6211d416d 100644 > --- a/hw/rdma/vmw/pvrdma_main.c > +++ b/hw/rdma/vmw/pvrdma_main.c > @@ -455,6 +455,11 @@ static const MemoryRegionOps regs_ops = { > }, > }; > > +static uint64_t uar_read(void *opaque, hwaddr addr, unsigned size) > +{ > + return 0; > +} > + > static void uar_write(void *opaque, hwaddr addr, uint64_t val, unsigned size) > { > PVRDMADev *dev = opaque; > @@ -496,6 +501,7 @@ static void uar_write(void *opaque, hwaddr addr, uint64_t > val, unsigned size) > } > > static const MemoryRegionOps uar_ops = { > + .read = uar_read,
Are you sure it is needed? Looking at memory_region_dispatch_read1 i can see that there is a check but not sure this is the right place. Anyways, if it is not, i believe this should be framework responsibility. > .write = uar_write, > .endianness = DEVICE_LITTLE_ENDIAN, > .impl = { > -- > 2.19.2 >