On 12/11/18 1:47 PM, Wainer dos Santos Moschetta wrote:
Yes, it helped a lot, thanks. And I apologize for my mistake, I'm gonna send a v3 fixing it.
You may want to wait a day or so for any other comments on v2, to minimize the resend churn. A maintainer can fix up tags, particularly when they are aware it is from a newer contributor still learning how things work.
Another doubt that I have: is it advisable to CC everyone that reviewed (with or without R-by) the previous version of my patch?
CC'ing previous reviewers is generally a reasonable idea, since they are then more likely to double-check that the things they pointed out in the first version are indeed fixed in the respin (and since without the cc, it's a lot easier to miss that a respin is even available on-list for followup review, thanks to the list traffic volume). You might not get a reply from everyone cc'd, but that's not fatal to acceptance of the patch.
-- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3266 Virtualization: qemu.org | libvirt.org
