On 12/12/18 9:30 PM, P J P wrote:
From: Prasad J Pandit <p...@fedoraproject.org>
Define skeleton 'uar_read' routine. Avoid NULL dereference.
Reported-by: Li Qiang <liq...@163.com>
Signed-off-by: Prasad J Pandit <p...@fedoraproject.org>
---
hw/rdma/vmw/pvrdma_main.c | 6 ++++++
1 file changed, 6 insertions(+)
Update: change return value from uar_read()
-> https://lists.gnu.org/archive/html/qemu-devel/2018-12/msg02787.html
diff --git a/hw/rdma/vmw/pvrdma_main.c b/hw/rdma/vmw/pvrdma_main.c
index 23dc9926e3..997d7f395a 100644
--- a/hw/rdma/vmw/pvrdma_main.c
+++ b/hw/rdma/vmw/pvrdma_main.c
@@ -448,6 +448,11 @@ static const MemoryRegionOps regs_ops = {
},
};
+static uint64_t uar_read(void *opaque, hwaddr addr, unsigned size)
+{
+ return 0xffffffff;
+}
+
static void uar_write(void *opaque, hwaddr addr, uint64_t val, unsigned size)
{
PVRDMADev *dev = opaque;
@@ -489,6 +494,7 @@ static void uar_write(void *opaque, hwaddr addr, uint64_t
val, unsigned size)
}
static const MemoryRegionOps uar_ops = {
+ .read = uar_read,
.write = uar_write,
.endianness = DEVICE_LITTLE_ENDIAN,
.impl = {
Reviewed-by: Marcel Apfelbaum <marcel.apfelb...@gmail.com>
Thanks,
Marcel
