On Thu, Dec 13, 2018 at 07:38:03AM +0100, Thomas Huth wrote: > On 2018-10-30 13:35, Kashyap Chamarthy wrote: > > The intended functionality of QMP `cpu-add` is replaced with > > `device_add` (and `query-hotpluggable-cpus`). So let's deprecate > > `cpu-add`. > > > > A complete example of vCPU hotplug with the recommended way (using > > `device_add`) is provided as part of a seperate docs patch. > > > > Suggested-by: Eduardo Habkost <ehabk...@redhat.com > > Signed-off-by: Kashyap Chamarthy <kcham...@redhat.com> > > --- > [...] > > diff --git a/qemu-deprecated.texi b/qemu-deprecated.texi > > index 1b9c007f12..c86924ad9a 100644 > > --- a/qemu-deprecated.texi > > +++ b/qemu-deprecated.texi > > @@ -155,6 +155,11 @@ The ``query-cpus'' command is replaced by the > > ``query-cpus-fast'' command. > > The ``arch'' output member of the ``query-cpus-fast'' command is > > replaced by the ``target'' output member. > > > > +@subsection cpu-add (since 3.1) > > Hi Kashyap, > > could you please send a follow-up patch to change this into 4.0 now?
Ah, sure. > Please also provide a patch to add the HMP command to > qemu-deprecated.texi, too. Is it okay if both the above are done in the same patch? Since they're related. Or am I missing a reason to do them separately? -- /kashyap