On 2018-12-13 13:02, Peter Maydell wrote: > Taking the address of a field in a packed struct is a bad idea, because > it might not be actually aligned enough for that pointer type (and > thus cause a crash on dereference on some host architectures). Newer > versions of clang warn about this. > > Avoid the problem by using local copies of the PMCW and SCSW > struct fields in copy_schib_from_guest() and copy_schib_to_guest(). > > Signed-off-by: Peter Maydell <peter.mayd...@linaro.org> > --- > v1->v2 changes: > * add comment about why we're using locals
Thanks! Reviewed-by: Thomas Huth <th...@redhat.com>
