Patchew URL: https://patchew.org/QEMU/20181213142719.592-1-cferg...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 20181213142719.592-1-cferg...@redhat.com Subject: [Qemu-devel] [PATCH v3] log: Make glib logging go through QEMU === TEST SCRIPT BEGIN === #!/bin/bash BASE=base n=1 total=$(git log --oneline $BASE.. | wc -l) failed=0 git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram commits="$(git log --format=%H --reverse $BASE..)" for c in $commits; do echo "Checking PATCH $n/$total: $(git log -n 1 --format=%s $c)..." if ! git show $c --format=email | ./scripts/checkpatch.pl --mailback -; then failed=1 echo fi n=$((n+1)) done exit $failed === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 4da29cf log: Make glib logging go through QEMU === OUTPUT BEGIN === Checking PATCH 1/1: log: Make glib logging go through QEMU... ERROR: space prohibited between function name and open parenthesis '(' #133: FILE: util/qemu-error.c:364: + if (strcmp (qemu_glog_domains, "all") != 0 && ERROR: space prohibited between function name and open parenthesis '(' #134: FILE: util/qemu-error.c:365: + (log_domain == NULL || !strstr (qemu_glog_domains, log_domain))) { total: 2 errors, 0 warnings, 107 lines checked Your patch has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20181213142719.592-1-cferg...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com