On 2018-12-13 22:00, Juan Quintela wrote: > Reviewed-by: Laurent Vivier <lviv...@redhat.com> > Signed-off-by: Juan Quintela <quint...@redhat.com> > > --- > > Also disable virtio9p test (lvivier) [...] > diff --git a/tests/Makefile.include b/tests/Makefile.include > index dd7c882cc5..90d33bb058 100644 > --- a/tests/Makefile.include > +++ b/tests/Makefile.include > @@ -151,7 +151,7 @@ check-qtest-virtio-y += tests/virtio-blk-test$(EXESUF) > check-qtest-virtio-$(CONFIG_VIRTIO_RNG) += tests/virtio-rng-test$(EXESUF) > check-qtest-virtio-y += tests/virtio-scsi-test$(EXESUF) > ifeq ($(CONFIG_VIRTIO)$(CONFIG_VIRTFS)$(CONFIG_PCI),yyy)
I guess you could remove the CONFIG_VIRTIO in above line now, since CONFIG_VIRTIO_9P should always be disabled when CONFIG_VIRTIO is disabled, too. ... anyway, does not hurt to keep it here either. > -check-qtest-virtio-y += tests/virtio-9p-test$(EXESUF) > +check-qtest-virtio-$(CONFIG_VIRTIO_9P) += tests/virtio-9p-test$(EXESUF) > endif > check-qtest-virtio-y += tests/virtio-serial-test$(EXESUF) > check-qtest-virtio-y += $(check-qtest-virtioserial-y) Reviewed-by: Thomas Huth <th...@redhat.com>