On 12/13/2018 04:01 PM, Peter Maydell wrote:
On Thu, 13 Dec 2018 at 17:57, Wainer dos Santos Moschetta <waine...@redhat.com> wrote:Eduardo Habkost pointed out a malformed block of comments on my patch [1] that I had ran checkpatch.pl and no warn/error was reported. Then I realized the script does not catch such as case (or it had a bug). It turns out that checkpatch.pl does not parse comment blocks (If I understood its code correctly...). So I implemented a checker that warns about: 1. block doesn't begin on its own line. Example: /* blah blah * and blah blah */I sent a patch to do this a little while back: https://patchwork.kernel.org/patch/10561557/
Self-NACK my patch in favor of that, which has additional checks (e.g. * alignment).
It didn't get applied because Paolo disagreed with having our tools enforcing what our style guide says. Personally I think we should just commit my patch, and then we can stop having people manually pointing out where submitters' patches don't match CODING_STYLE.
I am afraid that I can't give a firm option on this topic because it precedes my existence in this community, regardless I tend to agreed on Peter's reasoning.
Thanks! - Wainer T
thanks -- PMM
