On 03/14/2011 07:28 AM, jes.soren...@redhat.com wrote:
From: Jes Sorensen<jes.soren...@redhat.com>
This patch introduces a -display argument which consolidates the
setting of the display mode. Valid options are:
sdl/curses/default/nographic
Signed-off-by: Jes Sorensen<jes.soren...@redhat.com>
I'd suggest using 'serial' instead of 'nographic' as that makes it more
obvious to the user that they need to configure a serial session.
I would drop 'default' for no other reason than we don't really expose
default as a choice anywhere else and I'm struggling to justify it to
myself.
I think we also need to leave room to make -display take per-display
specific parameters via QemuOpts. That said, converting -vnc to
QemuOpts is hard so what I'd suggest doing is just cheating for the
moment. Document the option to take per-display args after the main
display, and then do something like:
if (strstarts(optarg, "vnc,", &p)) {
vnc_display_init(p);
}
We have a bunch of little stupid SDL options like -sdl-no-frame and it
would be good to eventually be able to express that as -display
sdl,frame=off
Regards,
Anthony Liguori
