On Thu, Jan 03, 2019 at 03:03:20PM +0100, BALATON Zoltan wrote: > On Wed, 2 Jan 2019, David Gibson wrote: > > On Wed, Jan 02, 2019 at 03:06:38AM +0100, BALATON Zoltan wrote: > > > To avoid overflow if larger values are added later use ram_addr_t for > > > the sdram_bank_sizes parameter to match ram_size to which it is > > > compared. > > > > So, technically I think these should be 'hwaddr' (which represents a > > guest physical address) rather tham ram_addr_t which > > represents... something subtley different I've never properly > > understood. > > I don't understand the difference either but ram_size in MachineState where > this value comes from is ram_addr_t now so I've left is for now. If someone > knows which type should this be can change it in another patch > later.
Ok, fair enough. -- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson
signature.asc
Description: PGP signature