On 12/15/18 7:53 AM, Eric Blake wrote: > There's no need to read into a temporary buffer (oversized > since commit 7d3123e1) followed by a byteswap into a uint64_t > to check for a magic number via memcmp(), when the code > immediately below demonstrates reading into the uint64_t then > byteswapping in place and checking for a magic number via > integer math. What's more, having a different error message > when the server's first reply byte is 0 is unusual - it's no > different from any other wrong magic number, and we already > detected short reads. That whole strlen() issue has been > present and useless since commit 1d45f8b5 in 2010; perhaps it > was leftover debugging (since the correct magic number happens > to be ASCII)? Make the error messages more consistent and > detailed while touching things. > > Signed-off-by: Eric Blake <ebl...@redhat.com> > Reviewed-by: Richard W.M. Jones <rjo...@redhat.com> > Reviewed-by: Vladimir Sementsov-Ogievskiy <vsement...@virtuozzo.com>
I'm queuing 1, 2, 5, 6, and 8 for my next NBD pull request, and will respin the rest of the series to incorporate review comments. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
