On Thu, Jan 03, 2019 at 03:15:44PM +0100, Thomas Huth wrote: > Hi, > > On 2018-12-27 07:33, Yang Zhong wrote: > > From: Paolo Bonzini <pbonz...@redhat.com> > > > > Do not link it unconditionally into all binaries. > > > > Signed-off-by: Paolo Bonzini <pbonz...@redhat.com> > > --- > > hw/pci-host/Makefile.objs | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/hw/pci-host/Makefile.objs b/hw/pci-host/Makefile.objs > > index 6d6597c065..9d7e7cd1b8 100644 > > --- a/hw/pci-host/Makefile.objs > > +++ b/hw/pci-host/Makefile.objs > > @@ -1,4 +1,4 @@ > > -common-obj-y += pam.o > > +common-obj-$(CONFIG_PAM) += pam.o > > CONFIG_PAM has been removed in the default-configs with commit > > a3b6e2bb71e6495a44f24e2296ab4feb4b6d4818 > default-configs: remove CONFIG_PAM > > ... so if you want to use it now, you've got to revert that commit, too. > > Thomas
Thanks Thomas for your reminder! Since default-configs/x86_64-softmmu.mak has only include i386-softmmu.mak file now, It's is hard to directly revert this patch, i will merge CONFIG_PAM=y into i386-softmmu.mak with this patch. thanks! Regards, Yang