On Mon, 7 Jan 2019 16:04:35 +0000 Peter Maydell <peter.mayd...@linaro.org> wrote:
> On Mon, 7 Jan 2019 at 15:57, Cornelia Huck <coh...@redhat.com> wrote: > > On Mon, 7 Jan 2019 15:54:21 +0000 > > Peter Maydell <peter.mayd...@linaro.org> wrote: > > > On Mon, 7 Jan 2019 at 15:48, Cornelia Huck <coh...@redhat.com> wrote: > > > > Sounds good. But please return anyway in the unplug case, so that the > > > > code is fine if asserts have been configured out. > > > > > > Hopefully that won't cause the compiler to complain about > > > unreachable code :-) > > > > BTW: Is there a common configuration where asserts are configured out? > > Not that this is an accident waiting to happen... > > No -- we insist they are always enabled, and osdep.h will #error > out if either NDEBUG or G_DISABLE_ASSERT are set. Ah, now I remember (I thought we still had that problem.) In that case, no return is needed.
