On Sat, Jan 05, 2019 at 03:32:13PM +0000, Peter Maydell wrote: > On Thu, 27 Dec 2018 at 06:35, Yang Zhong <yang.zh...@intel.com> wrote: > > > > Only keep same boards definitions as i386-softmmu.mak in > > x86_64-softmmu.mak. > > > > Signed-off-by: Yang Zhong <yang.zh...@intel.com> > > --- > > default-configs/x86_64-softmmu.mak | 6 +++++- > > 1 file changed, 5 insertions(+), 1 deletion(-) > > > > diff --git a/default-configs/x86_64-softmmu.mak > > b/default-configs/x86_64-softmmu.mak > > index 64b2ee2960..0c69c2930c 100644 > > --- a/default-configs/x86_64-softmmu.mak > > +++ b/default-configs/x86_64-softmmu.mak > > @@ -1,3 +1,7 @@ > > # Default configuration for x86_64-softmmu > > > > -include i386-softmmu.mak > > +# Boards: > > +# > > +CONFIG_ISAPC=y > > +CONFIG_I440FX=y > > +CONFIG_Q35=y > > Could you explain the rationale for doing this? Now > any new i386 board has to be added in two places, > doesn't it? > > thanks > -- PMM
Thanks Peter, you are right, i will remove this patch in next version, thanks! Regards, Yang