On Fri, 4 Jan 2019 19:12:06 +0100 Philippe Mathieu-Daudé <phi...@redhat.com> wrote:
> The size_to_str() function doesn't need to be in a generic header. > > It makes also sens to find this function in the same header than > the opposite string to size functions: qemu_strtosz*(). > Note than this function is already implemented in util/cutils.c. > > Since we introduce a new function in a header, we document it, > using the previous comment from the source file. > > Signed-off-by: Philippe Mathieu-Daudé <phi...@redhat.com> > --- > include/qemu-common.h | 1 - > include/qemu/cutils.h | 13 +++++++++++++ > qapi/string-output-visitor.c | 2 +- > util/cutils.c | 6 ------ > 4 files changed, 14 insertions(+), 8 deletions(-) With the patch description fixed (as noted by Eric): Reviewed-by: Cornelia Huck <coh...@redhat.com>
