Or rather, move its functionality into nbd-server-add. And as a side effect, teach qemu-nbd how to export a persistent bitmap without having to go through a qemu process and several QMP commands.
Based-on: <20181221093529.23855-1-js...@redhat.com> [0/11 bitmaps: remove x- prefix from QMP api] Patch 5 was very lightly tested; I hope to have more time to play with that patch alongside Andrey's pending [qemu-img info lists bitmap directory entries], with an update to iotests to demonstrate how it is possible to inspect dirty bitmaps by using qemu-img to learn what is available then qemu-nbd to expose them. It's still painful that there are no qemu-img commands for creating a new persistent bitmap; that still has to be done via QMP on a live guest. Eric Blake (5): nbd: Merge nbd_export_set_name into nbd_export_new nbd: Allow bitmap export during QMP nbd-server-add nbd: Remove x-nbd-server-add-bitmap nbd: Merge nbd_export_bitmap into nbd_export_new qemu-nbd: Add --bitmap=NAME option qemu-nbd.texi | 5 ++ qapi/block.json | 35 ++++------- include/block/nbd.h | 7 +-- blockdev-nbd.c | 44 ++++++-------- hmp.c | 6 +- nbd/server.c | 121 ++++++++++++++++--------------------- qemu-nbd.c | 19 ++++-- tests/qemu-iotests/223 | 11 ++-- tests/qemu-iotests/223.out | 2 - 9 files changed, 109 insertions(+), 141 deletions(-) -- 2.20.1
