On Thu, 10 Jan 2019 00:02:57 -0200 Eduardo Habkost <ehabk...@redhat.com> wrote:
> When handling errp==NULL at object_apply_global_props(), we are > leaving the old error value in `err` after printing a warning. > This makes QEMU crash if two global properties generate warnings: > > $ echo device_add rtl8139 | qemu-system-x86_64 -monitor stdio -global > rtl8139.xxx=yyy -global rtl8139.xxx=zzz > warning: can't apply global rtl8139.xxx=yyy: Property '.xxx' not found > qemu-system-x86_64: util/error.c:57: error_setv: Assertion `*errp == NULL' > failed. > Aborted (core dumped) > > Fix that by making `err` go out of scope immediately after the > warn_report_err() call. > > Fixes: 50545b2cc029 "qdev-props: call object_apply_global_props()" > Signed-off-by: Eduardo Habkost <ehabk...@redhat.com> > --- > qom/object.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Reviewed-by: Cornelia Huck <coh...@redhat.com>
