Am 10.01.2019 um 19:22 hat Eric Blake geschrieben: > On 1/10/19 11:06 AM, Dr. David Alan Gilbert wrote: > > >>> savevm [-t] [-i] [tag|id] > >>> > >>> then: > >>> a) with neither -t or -i it would behave in the same roulette way > >>> as it does in the moment, and it might be a tag or id > >>> > >>> b) with -t we'd explicitly treat the parameter as a tag and it > >>> would error if it wasn't found > >>> > >>> c) With -i we'd explicitly treat the parameter as an id and > >>> it would error if it wasn't found > >>> > >>> Since we still allow (a) it doesn't break any existing code. > >> > >> If you can explain why we need both tag and id? > >> > >> And by keeping the current behaviour, we might not break hypothetically > >> existing correct code, but we leave currently actually existing broken > >> code like libvirt broken. > > > > My only reason for leaving both tag & id was for the hypothetical > > existing current code; my assumption adding the above would be that we > > would then fix libvirt never to use (a), probably always (b). > > How? HMP is not introspectible, so libvirt can't know if 'savevm -t' > works without trying it.
It is introspectible in a way, 'help savevm'. Just that the result of that isn't machine readable and not meant to be parsed by programs. But that's just what happens when you use HMP. I'm still against the proposal because it makes the interface more complicated rather than simpler. Kevin
signature.asc
Description: PGP signature
