On 11/01/19 23:39, Philippe Mathieu-Daudé wrote: > On 1/11/19 10:28 PM, no-re...@patchew.org wrote: >> Patchew URL: >> https://patchew.org/QEMU/20190111155555.8270-1-phi...@redhat.com/ >> >> Hi, >> >> This series seems to have some coding style problems. See output below for >> more information: >> >> Message-id: 20190111155555.8270-1-phi...@redhat.com >> Type: series >> Subject: [Qemu-devel] [PATCH] contrib/gitdm: Fix a typo >> >> === TEST SCRIPT BEGIN === >> #!/bin/bash >> git config --local diff.renamelimit 0 >> git config --local diff.renames True >> git config --local diff.algorithm histogram >> ./scripts/checkpatch.pl --mailback --color=always base.. > I suppose Paolo expected his PR to land to upgrade patchew, and patchew > is still processing from an old queue? >
Yeah, patchew was still processing tags that didn't have my PR applied. Anyhow, I'll hijack this to note that now: 1) The test script for checkpatch is now much simple, compare https://patchew.org/QEMU/20190103085638.17600-1-phi...@redhat.com/ (old) to https://patchew.org/QEMU/20190109110144.18633-1-stefa...@redhat.com/ (new). Improvement of "cut and paste" ability was a nice side effect of the new TAP-based "make check", and this goes in the same direction. 2) Patchew is showing colored output---for now only for checkpatch. :) More precisely, output is captured from a PTY, via script(1). This turned out to be a bit more tricky than I expected (script doesn't like having its stdin redirected from /dev/null), but it's fixed now. 3) I bumped the tester from -j8 to -j14, hoping that the queue will be smaller, and temporarily deployed a second tester on my own workstation. This in turn caused some issues because pulling a git repo with 12000 tags is not for the faint of heart, but everything should be running normally now and future deployments will optimize this (check https://patchew.org/Patchew/ to see the issues). Paolo