Re: [Qemu-devel] [PATCH] hw/misc/edu: add msi_uninit() for pci_edu_uninit()

[Marcel Apfelbaum]

On 1/13/19 4:36 PM, Fei Li wrote:

From: Fei Li <shirley17...@gmail.com>

Let's supplement the msi_uninit() when failing to realize
the pci edu device.

Cc: Markus Armbruster <arm...@redhat.com>
Cc: Peter Xu <pet...@redhat.com>
Cc: Michael S. Tsirkin <m...@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelb...@gmail.com>
Signed-off-by: Fei Li <shirley17...@gmail.com>
---
  hw/misc/edu.c | 1 +
  1 file changed, 1 insertion(+)

diff --git a/hw/misc/edu.c b/hw/misc/edu.c
index cdcf550dd7..4feb7503de 100644
--- a/hw/misc/edu.c
+++ b/hw/misc/edu.c
@@ -367,6 +367,7 @@ static void pci_edu_uninit(PCIDevice *pdev)
  {
      EduState *edu = EDU(pdev);

+ msi_uninit(pdev);

      qemu_mutex_lock(&edu->thr_mutex);
      edu->stopping = true;
      qemu_mutex_unlock(&edu->thr_mutex);

Reviewed-by: Marcel Apfelbaum<marcel.apfelb...@gmail.com>

Thanks,
Marcel