Have fixed in this patch. https://lists.nongnu.org/archive/html/qemu-devel/2019-01/msg02859.html
Thanks Zhang Chen -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811499 Title: qemu/net/colo-compare.c:288: possible pointless code duplication ? Status in QEMU: New Bug description: qemu/net/colo-compare.c:288] -> [qemu/net/colo-compare.c:296]: (style) The if condition is the same as the previous if condition Source code is if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) { if (colo_compare_packet_payload(ppkt, spkt, ppkt->header_size, spkt->header_size, ppkt->payload_size)) { *mark = COLO_COMPARE_FREE_SECONDARY | COLO_COMPARE_FREE_PRIMARY; return true; } } if (ppkt->tcp_seq == spkt->tcp_seq && ppkt->seq_end == spkt->seq_end) { if (colo_compare_packet_payload(ppkt, spkt, ppkt->header_size, spkt->header_size, ppkt->payload_size)) { *mark = COLO_COMPARE_FREE_SECONDARY | COLO_COMPARE_FREE_PRIMARY; return true; } } Maybe the second block was supposed to be different ? To manage notifications about this bug go to: https://bugs.launchpad.net/qemu/+bug/1811499/+subscriptions