Hi Cornelia, On 1/15/19 1:12 PM, Cornelia Huck wrote: > On Fri, 11 Jan 2019 17:58:01 +0100 > Eric Auger <eric.au...@redhat.com> wrote: > >> We can also use vfio_register_event_notifier() helper in >> vfio_intx_enable_kvm to set the signalling associated to >> VFIO_PCI_INTX_IRQ_INDEX. >> >> Signed-off-by: Eric Auger <eric.au...@redhat.com> >> --- >> hw/vfio/pci.c | 38 +++++++------------------------------- >> 1 file changed, 7 insertions(+), 31 deletions(-) >> > >> static void vfio_intx_disable(VFIOPCIDevice *vdev) > > I'm wondering why the _disable path can't use the new helper. Ordering > issues? > Yes the interleaving of actions scared me a little bit. I am going to study this a little bit further ...
Thanks Eric
