On Tue, Jan 15, 2019 at 02:09:12PM +0000, Stefan Hajnoczi wrote: > > In these codepaths, I'm confident up to > > void monitor_vfprintf(FILE *stream, const char *fmt, va_list ap) > > { > > if (cur_mon && !monitor_cur_is_qmp()) { > > monitor_vprintf(cur_mon, fmt, ap); > > } else { > > vfprintf(stream, fmt, ap); > > } > > } > > > > From there, it was not obvious to me whether the monitor_vprintf > > codepath can be triggered from info/warn/error_report or not. If they > > can, I'd feel less confident that monitor_vprintf will never indirectly > > call glib log functions. > > I think we're okay because otherwise monitor_vprintf() -> > info/warn/error_report() would already be an infinite loop today.
Ah good point :) Christophe
signature.asc
Description: PGP signature