On 1/15/19 4:24 AM, Dr. David Alan Gilbert wrote: > I think the problem is that > migrate_params_check checks a MigrationParameters > > while the QMP command gives us a MigrateSetParameters; but we also use > migrate_params_check for the global check you added (8b0b29dc) which is > against migrationParameters; so that's why migrate_params_check takes > a MigrationParameters. > > It's horrible we've got stuff duped so much.
Indeed. > > However, I don't like this fix because if someone later was to add > a test for tls parameters to migrate_params_check, then they would be > confused why the hostname/creds weren't checked. > So while we have migrate_params_test_apply, it should cover all > parameters. > > I think a cleaner check would be to write a MigrateParameters_free > that free'd any strings, and call that in qmp_migrate_set_parameters > on both exit paths. We already have it; it's named qapi_free_MigrationParameters(), generated in qapi-types-migration.h. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
