On 03/16/2011 03:08 PM, Benjamin Herrenschmidt wrote:
On Wed, 2011-03-16 at 17:41 +0100, Alexander Graf wrote:

+/*
+ * Common MAD header
+ */
+struct mad_common {
+    uint32_t type;
+    uint16_t status;
+    uint16_t length;
+    uint64_t tag;
Is this an in-memory representation? If so, it should be packed, right?
Same goes for the ones below.
Well, all the fields are naturally aligned, as is the structure itself,
do we really need to pack ?

No.

Regards,

Anthony Liguori

Cheers,
Ben.





Reply via email to