On Tue, Jan 15, 2019 at 2:24 PM Richard Henderson <richard.hender...@linaro.org> wrote: > > On 1/15/19 10:58 AM, Alistair Francis wrote: > > -static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState > > *cs) > > +static void riscv_tr_init_disas_context(DisasContextBase *dcbase, CPUState > > *cpu) > > Why change this? I know there is variation in the naming, but my > preferred default mapping is CPUState *cs, RISCVCPU *cpu.
Good point, I have changed it back to cs. Alistair > > Otherwise, > Reviewed-by: Richard Henderson <richard.hender...@linaro.org> > > > r~