On 1/10/19 7:36 PM, BALATON Zoltan wrote:
> Hello,
>
> This series is a small refactoring that moves some common PCI IDE io
> mem ops functions from the CMD646 model to the PCI IDE model so a
> CMD646 specific type can be dropped from PCIIDEState, removes code
> duplication from SiI3112 model (also fixing a bug) and allows these
> functions to be used by future PCI IDE implementations.
>
> Also cc'd Mark and Richard because the CMD646 seems to be used by
> Sparc, HPPA and Alpha machines.
>
> Regards,
> BALATON Zoltan
>
> BALATON Zoltan (5):
> cmd646: Remove unused variable
> cmd646: Remove IDEBus from CMD646BAR
> cmd646: Move PCI IDE specific functions to ide/pci.c
> ide: Get rid of CMD646BAR struct
> sii3112: Remove duplicated code and use PCI IDE ops instead
>
> hw/ide/cmd646.c | 102
> ++++++++-------------------------------------------
> hw/ide/pci.c | 65 ++++++++++++++++++++++++++++++++
> hw/ide/sii3112.c | 52 ++++----------------------
> include/hw/ide/pci.h | 14 ++-----
> 4 files changed, 93 insertions(+), 140 deletions(-)
>
Hi, just a note to let you know I just got back from vacation and I will
take a little while to get to this as I unbury.
--js