> From: Markus Armbruster [mailto:arm...@redhat.com] > Pavel Dovgalyuk <pavel.dovga...@ispras.ru> writes: > > > This patch introduces replay_break, replay_delete_break > > qmp and hmp commands. > > These commands allow stopping at the specified instruction. > > It may be useful for debugging when there are some known > > events that should be investigated. > > replay_break command has one argument - number of instructions > > executed since the start of the replay. > > replay_delete_break removes previously set breakpoint. > > > > Signed-off-by: Pavel Dovgalyuk <pavel.dovga...@ispras.ru> > > > > -- > > + > > +static void replay_break(uint64_t icount, QEMUTimerCB callback, void > > *opaque) > > +{ > > + assert(replay_mode == REPLAY_MODE_PLAY); > > + assert(replay_mutex_locked()); > > + assert(replay_break_icount >= replay_get_current_step()); > > The identifier replay_get_current_step() is one of the few remaining > instances of "step" terminology. Whether to normalize them to "icount" > is entirely up to you.
This is already done with the last patch in the series. Pavel Dovgalyuk
