Emilio G. Cota <c...@braap.org> writes:
> On Thu, Jan 17, 2019 at 18:55:33 +0000, Peter Maydell wrote: >> On Thu, 17 Jan 2019 at 18:30, Emilio G. Cota <c...@braap.org> wrote: >> > What are the contents of "int-to-float.err"? >> >> linux1@lxub05:~$ cat qemu/build/all/tests/fp/int-to-float.err >> >> Testing i32_to_f16, rounding near_even >> 372 tests total. >> 372 tests performed. >> >> Testing i64_to_f16, rounding near_even >> 756 tests total. >> 756 tests performed. >> >> Testing i32_to_f32, rounding near_even >> 372 tests total. >> 372 tests performed. >> >> Testing i64_to_f32, rounding near_even >> 756 tests total. >> 756 tests performed. >> >> Testing i32_to_f64 >> 372 tests total. >> 372 tests performed. >> >> Testing i64_to_f64, rounding near_even >> 756 tests total. >> 756 tests performed. >> >> Testing i32_to_f128 >> 372 tests total. >> 21 tests performed; 20 errors found. > > I see, so i32_to_f128 is failing on this host. Is there > a s390x machine I could access? I don't see one in the > gcc compile farm. I've managed to reproduce this in a s390x VM, for Debian install runes: https://wiki.qemu.org/Documentation/Platforms/S390X#Debian_Install_Example_.28TCG.29 > >> > diff --git a/tests/fp/Makefile b/tests/fp/Makefile >> > index 5019dcdca0..5a35e7c210 100644 >> > --- a/tests/fp/Makefile >> > +++ b/tests/fp/Makefile >> > @@ -65,8 +65,7 @@ QEMU_CFLAGS += $(TF_OPTS) >> > TF_CFLAGS := >> > TF_CFLAGS += -Wno-strict-prototypes >> > TF_CFLAGS += -Wno-unknown-pragmas >> > -TF_CFLAGS += -Wno-discarded-qualifiers >> > -TF_CFLAGS += -Wno-maybe-uninitialized >> > +TF_CFLAGS += -Wno-uninitialized >> > TF_CFLAGS += -Wno-missing-prototypes >> > TF_CFLAGS += -Wno-return-type >> > TF_CFLAGS += -Wno-unused-function >> >> configure has logic to check whether it can use particular >> warning enable/disable flags. Newer gcc (and I hope clang >> but forget) will happily silently allow -Wno-random-new-thing >> even if they don't support -Wrandom-new-thing) but I'm not >> sure our minimum compiler version is yet new enough to >> be able to rely on that (indeed the warning messages suggest >> it is not). > > I figured that -Wno-unitialized is documented to work on both > gcc and clang, and the change in testfloat drops the need > for no-discarded-qualifiers, so we can go with this without > messing with configure. Works for me, OK with you Peter? -- Alex Bennée