Patchew URL:
https://patchew.org/QEMU/20190115165710.20116-1-mhi...@scalecomputing.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190115165710.20116-1-mhi...@scalecomputing.com
Type: series
Subject: [Qemu-devel] [PATCH v2] QGA: Fix guest-get-fsinfo PCI address
collection in Windows
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
85a7940 QGA: Fix guest-get-fsinfo PCI address collection in Windows
=== OUTPUT BEGIN ===
WARNING: Block comments should align the * on each line
#195: FILE: qga/commands-win32.c:592:
+ /*
+ * CM API used here as opposed to
WARNING: line over 80 characters
#299: FILE: qga/commands-win32.c:661:
+ /* There is no need to allocate buffer in the next functions. The
size
WARNING: Block comments use a leading /* on a separate line
#299: FILE: qga/commands-win32.c:661:
+ /* There is no need to allocate buffer in the next functions. The
size
WARNING: Block comments should align the * on each line
#300: FILE: qga/commands-win32.c:662:
+ /* There is no need to allocate buffer in the next functions. The
size
+ * is known and ULONG according to
ERROR: spaces required around that '&' (ctx:VxV)
#305: FILE: qga/commands-win32.c:667:
+ &type, (PBYTE)&bus, size, NULL)) {
^
WARNING: Block comments use a leading /* on a separate line
#323: FILE: qga/commands-win32.c:673:
+ /* The function retrieves the device's address. This value will be
WARNING: Block comments use a trailing */ on a separate line
#324: FILE: qga/commands-win32.c:674:
+ * transformed into device function and number */
WARNING: Block comments should align the * on each line
#324: FILE: qga/commands-win32.c:674:
+ /* The function retrieves the device's address. This value will be
+ * transformed into device function and number */
ERROR: spaces required around that '&' (ctx:VxV)
#327: FILE: qga/commands-win32.c:677:
+ &type, (PBYTE)&addr, size, NULL)) {
^
WARNING: Block comments use a leading /* on a separate line
#333: FILE: qga/commands-win32.c:683:
+ /* This call returns UINumber of DEVICE_CAPABILITIES structure.
WARNING: Block comments use a trailing */ on a separate line
#334: FILE: qga/commands-win32.c:684:
+ * This number is typically a user-perceived slot number. */
WARNING: Block comments should align the * on each line
#334: FILE: qga/commands-win32.c:684:
+ /* This call returns UINumber of DEVICE_CAPABILITIES structure.
+ * This number is typically a user-perceived slot number. */
ERROR: spaces required around that '&' (ctx:VxV)
#337: FILE: qga/commands-win32.c:687:
+ &type, (PBYTE)&slot, size, NULL)) {
^
WARNING: Block comments use a leading /* on a separate line
#343: FILE: qga/commands-win32.c:693:
+ /* SetupApi gives us the same information as driver with
WARNING: Block comments should align the * on each line
#344: FILE: qga/commands-win32.c:694:
+ /* SetupApi gives us the same information as driver with
+ * IoGetDeviceProperty. According to Microsoft
WARNING: Block comments use a trailing */ on a separate line
#348: FILE: qga/commands-win32.c:698:
+ * SPDRP_ADDRESS is propertyAddress, so we do the same.*/
total: 3 errors, 13 warnings, 394 lines checked
Commit 85a794036de8 (QGA: Fix guest-get-fsinfo PCI address collection in
Windows) has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190115165710.20116-1-mhi...@scalecomputing.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
