On Tue, Jan 22, 2019 at 01:57:50PM +1100, Alexey Kardashevskiy wrote: > > > On 21/01/2019 20:35, Peter Xu wrote: > > On Mon, Jan 21, 2019 at 12:32:07AM -0800, no-re...@patchew.org wrote: > >> Patchew URL: > >> https://patchew.org/QEMU/20190116030815.27273-1-pet...@redhat.com/ > >> > >> > >> > >> Hi, > >> > >> This series failed the docker-mingw@fedora build test. Please find the > >> testing commands and > >> their output below. If you have Docker installed, you can probably > >> reproduce it > >> locally. > >> > >> === TEST SCRIPT BEGIN === > >> #!/bin/bash > >> time make docker-test-mingw@fedora SHOW_ENV=1 J=14 > >> === TEST SCRIPT END === > >> > >> CC hw/block/pflash_cfi01.o > >> In function 'acpi_table_install', > >> inlined from 'acpi_table_add' at > >> /tmp/qemu-test/src/hw/acpi/core.c:296:5: > >> /tmp/qemu-test/src/hw/acpi/core.c:184:9: error: 'strncpy' specified bound > >> 4 equals destination size [-Werror=stringop-truncation] > >> strncpy(ext_hdr->sig, hdrs->sig, sizeof ext_hdr->sig); > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> /tmp/qemu-test/src/hw/acpi/core.c:203:9: error: 'strncpy' specified bound > >> 6 equals destination size [-Werror=stringop-truncation] > >> strncpy(ext_hdr->oem_id, hdrs->oem_id, sizeof ext_hdr->oem_id); > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> /tmp/qemu-test/src/hw/acpi/core.c:207:9: error: 'strncpy' specified bound > >> 8 equals destination size [-Werror=stringop-truncation] > >> strncpy(ext_hdr->oem_table_id, hdrs->oem_table_id, > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> sizeof ext_hdr->oem_table_id); > >> ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> /tmp/qemu-test/src/hw/acpi/core.c:216:9: error: 'strncpy' specified bound > >> 4 equals destination size [-Werror=stringop-truncation] > >> strncpy(ext_hdr->asl_compiler_id, hdrs->asl_compiler_id, > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> sizeof ext_hdr->asl_compiler_id); > >> --- > >> make: *** [/tmp/qemu-test/src/rules.mak:69: hw/acpi/core.o] Error 1 > >> make: *** Waiting for unfinished jobs.... > >> /tmp/qemu-test/src/block/sheepdog.c: In function 'find_vdi_name': > >> /tmp/qemu-test/src/block/sheepdog.c:1239:5: error: 'strncpy' specified > >> bound 256 equals destination size [-Werror=stringop-truncation] > >> strncpy(buf + SD_MAX_VDI_LEN, tag, SD_MAX_VDI_TAG_LEN); > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> cc1: all warnings being treated as errors > >> make: *** [/tmp/qemu-test/src/rules.mak:69: block/sheepdog.o] Error 1 > >> /tmp/qemu-test/src/hw/acpi/aml-build.c: In function 'build_header': > >> /tmp/qemu-test/src/hw/acpi/aml-build.c:1535:9: error: 'strncpy' specified > >> bound 6 equals destination size [-Werror=stringop-truncation] > >> strncpy((char *)h->oem_id, oem_id, sizeof h->oem_id); > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> /tmp/qemu-test/src/hw/acpi/aml-build.c:1541:9: error: 'strncpy' specified > >> bound 8 equals destination size [-Werror=stringop-truncation] > >> strncpy((char *)h->oem_table_id, oem_table_id, > >> sizeof(h->oem_table_id)); > >> > >> ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > >> cc1: all warnings being treated as errors > > > > I'm uncertain about these errors but it seems to be more likely to be > > caused by some configuration or compiler change instead of the series > > itself since this series never changed either acpi or sheepdog code. > > So I'll temporarily ignore them... > > > I am getting these too and I do not touch the mentioned files and > folders ever. > > > > -- > Alexey
You want 9cbb8eca1729eab1123847e37454975bb555008a I think. -- MST
