On 2019-01-24 18:37, Mark Cave-Ayland wrote: > On 24/01/2019 17:15, Laurent Vivier wrote: > >> On 24/01/2019 18:02, Thomas Huth wrote: >>> On 2018-11-02 16:22, Mark Cave-Ayland wrote: >>>> (MCA: here's the latest version of the q800 patchset. I've hope that I've >>>> addressed most of the comments, plus this will now boot into the Debian >>>> installer correctly when applied to git master. >>> >>> Any update on this series? Why did it get stalled again? >>> >> >> I was thinking about this today. >> >> Mark, perhaps you can send a rebased version of the series? >> >> I think we need reviews for "esp: add pseudo-DMA as used by Macintosh".
I just gave it a quick review (see my separate mail) ... some few nits, but all in all, it looks quite good to me. > 1) Do we mind some of the more verbose comments that were taken from the Linux > headers in some of the files? (I can also see that updates to the comment > checking in > checkpatch.pl now cause the series to fail with style issues, so these will > need to > be touched up regardless) I personally would clean them up, but that's just a matter of taste. I think that's nothing that should hold up this series. It can also be done with a patch on top afterwards. > 2) Do we need to add migration support for the ESP pseudo-DMA? That would be cleaner, of course. But since the q800 likely can't be migrated anyway, it's not that important. So if it is too much of a hassle to add it, maybe simply add a comment next to the vmstate section saying "/* TODO: Add migration support for the pdma data */" ? Thomas
