On 21 March 2011 13:48, Nathan Froyd <froy...@codesourcery.com> wrote: > On Mon, Mar 14, 2011 at 05:23:11PM +0000, Peter Maydell wrote: >> Correct the argument and return types for the float<->int conversion helper >> functions so that integer arguments and return values are declared as >> uint32_t/uint64_t, not float32/float64.
> I like the direction this patch goes; you aren't by any chance going to > convert the passing/returning of float* to their appropriate int* types > too, are you? Nope -- I think that where we're passing or returning an actual IEEE single/double to a helper function "float*" is a better type than uint32_t: it gives information about what the helper's argument semantically is, and it means we don't have every helper that takes or returns a float have to include ugly calls to the boxing/unboxing macros. -- PMM