On 2019-01-25 17:44, Philippe Mathieu-Daudé wrote: > On 1/25/19 4:24 PM, Thomas Huth wrote: >> On 2019-01-25 16:14, kumar sourav wrote: >>> Sets the category of i8042 device as DEVICE_CATEGORY_INPUT >>> Devices should be assigned to one of DEVICE_CATEGORY_XXXX. >>> >>> Signed-off-by: kumar sourav <sourav.jb1...@gmail.com> >>> --- >>> hw/input/pckbd.c | 1 + > > It seems we have other potential cases: > > $ git grep -L 'set_bit(DEVICE_CATEGORY_INPUT' hw/input/*c > hw/input/adb.c > hw/input/hid.c > hw/input/lm832x.c > hw/input/milkymist-softusb.c > hw/input/pckbd.c > hw/input/pl050.c > hw/input/ps2.c > hw/input/pxa2xx_keypad.c > hw/input/stellaris_input.c > hw/input/tsc2005.c > hw/input/tsc210x.c > hw/input/virtio-input-hid.c > hw/input/virtio-input-host.c
Note that some of these are not even "qomified" yet (e.g. tsc2005), others are not creatable by the user (pl050) as far as I can see, so it does not make much sense to set a category for these devices yet. Thomas
