On 1/23/19 9:46 AM, Max Reitz wrote:
> With IMGOPTSSYNTAX, $TEST_IMG is useless for this test (it only tests
> the file-posix protocol driver). Therefore, if $TEST_IMG_FILE is set,
> use that instead.
>
> Because this test requires the file protocol, $TEST_IMG_FILE will always
> be set if $IMGOPTSSYNTAX is true.
>
> Signed-off-by: Max Reitz <mre...@redhat.com>
This keeps biting us. Or at least, it bit me once and then it has bitten
someone else. It's not obvious that you need to accommodate this when
writing a new test.
For now, anyway, this does give us a new bandaid for a while longer.
Reviewed-by: John Snow <js...@redhat.com>
> ---
> tests/qemu-iotests/232 | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/tests/qemu-iotests/232 b/tests/qemu-iotests/232
> index 93e5d641a3..e48bc8f5db 100755
> --- a/tests/qemu-iotests/232
> +++ b/tests/qemu-iotests/232
> @@ -69,6 +69,10 @@ size=128M
>
> _make_test_img $size
>
> +if [ -n "$TEST_IMG_FILE" ]; then
> + TEST_IMG=$TEST_IMG_FILE
> +fi
> +
> echo
> echo "=== -drive with read-write image: read-only/auto-read-only
> combinations ==="
> echo
>
--
—js
