Patchew URL:
https://patchew.org/QEMU/20190123225705.28963-1-richard.hender...@linaro.org/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PATCH 00/13] Dynamic TLB sizing, backends
Type: series
Message-id: 20190123225705.28963-1-richard.hender...@linaro.org
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
Switched to a new branch 'test'
a08f6bec93 cputlb: Remove static tlb sizing
0efd0464f0 tcg/tci: enable dynamic TLB sizing
b53d9afec3 tcg/mips: enable dynamic TLB sizing
c2b46736e8 tcg/mips: Fix tcg_out_qemu_ld_slow_path
72aa447a49 tcg/arm: enable dynamic TLB sizing
2b4d1fa8bd tcg/riscv: enable dynamic TLB sizing
1cd52ed294 tcg/s390: enable dynamic TLB sizing
02c6510644 tcg/sparc: enable dynamic TLB sizing
91dd33b602 tcg/ppc: enable dynamic TLB sizing
cc0dc49d9a tcg/aarch64: enable dynamic TLB sizing
636758a24d tcg/i386: enable dynamic TLB sizing
f530c788b5 tcg: introduce dynamic TLB sizing
5a02f1a0e4 cputlb: do not evict empty entries to the vtlb
=== OUTPUT BEGIN ===
1/13 Checking commit 5a02f1a0e498 (cputlb: do not evict empty entries to the
vtlb)
WARNING: Block comments use a leading /* on a separate line
#31: FILE: accel/tcg/cputlb.c:227:
+/**
total: 0 errors, 1 warnings, 23 lines checked
Patch 1/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
2/13 Checking commit f530c788b54e (tcg: introduce dynamic TLB sizing)
WARNING: Block comments use a leading /* on a separate line
#53: FILE: accel/tcg/cputlb.c:106:
+/**
WARNING: Block comments use a leading /* on a separate line
#336: FILE: include/exec/cpu-defs.h:167:
+/**
WARNING: Block comments use a leading /* on a separate line
#368: FILE: include/exec/cpu-defs.h:220:
+ /* tlb_mask[i] contains (n_entries - 1) << CPU_TLB_ENTRY_BITS */ \
total: 0 errors, 3 warnings, 452 lines checked
Patch 2/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/13 Checking commit 636758a24d06 (tcg/i386: enable dynamic TLB sizing)
4/13 Checking commit cc0dc49d9a08 (tcg/aarch64: enable dynamic TLB sizing)
5/13 Checking commit 91dd33b60211 (tcg/ppc: enable dynamic TLB sizing)
ERROR: space prohibited after that open parenthesis '('
#31: FILE: tcg/ppc/tcg-target.inc.c:330:
+#define LWZUX XO31( 55)
ERROR: space prohibited after that open parenthesis '('
#39: FILE: tcg/ppc/tcg-target.inc.c:342:
+#define LDUX XO31( 53)
total: 2 errors, 0 warnings, 144 lines checked
Patch 5/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
6/13 Checking commit 02c651064433 (tcg/sparc: enable dynamic TLB sizing)
7/13 Checking commit 1cd52ed29421 (tcg/s390: enable dynamic TLB sizing)
8/13 Checking commit 2b4d1fa8bd14 (tcg/riscv: enable dynamic TLB sizing)
9/13 Checking commit 72aa447a4981 (tcg/arm: enable dynamic TLB sizing)
ERROR: code indent should never use tabs
#174: FILE: tcg/arm/tcg-target.inc.c:1297:
+^Iif (use_armv6_instructions && TARGET_LONG_BITS == 64) {$
ERROR: code indent should never use tabs
#181: FILE: tcg/arm/tcg-target.inc.c:1304:
+^I^I TCG_REG_R2, TCG_REG_R2, TCG_REG_TMP, 0);$
ERROR: code indent should never use tabs
#186: FILE: tcg/arm/tcg-target.inc.c:1309:
+^I}$
total: 3 errors, 0 warnings, 177 lines checked
Patch 9/13 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
10/13 Checking commit c2b46736e852 (tcg/mips: Fix tcg_out_qemu_ld_slow_path)
11/13 Checking commit b53d9afec346 (tcg/mips: enable dynamic TLB sizing)
12/13 Checking commit 0efd0464f0c7 (tcg/tci: enable dynamic TLB sizing)
13/13 Checking commit a08f6bec93d1 (cputlb: Remove static tlb sizing)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190123225705.28963-1-richard.hender...@linaro.org/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-de...@redhat.com
