Patchew URL: https://patchew.org/QEMU/20190128223118.5255-1-richard.hender...@linaro.org/
Hi, This series seems to have some coding style problems. See output below for more information: Subject: [Qemu-devel] [PATCH v2 00/12] target/arm: Implement ARMv8.5-BTI Type: series Message-id: 20190128223118.5255-1-richard.hender...@linaro.org === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 Switched to a new branch 'test' 18c0b24bcd tests/tcg/aarch64: Add bti smoke test d5315467cf linux-user/aarch64: Reset btype for syscalls and signals ba139e0144 target/arm: Enable BTI for -cpu max 1a387cb4b4 target/arm: Add x-guarded-pages cpu property for user-only b3fbe9ad27 target/arm: Set btype for indirect branches 905ade3305 target/arm: Reset btype for direct branches 57cafb41c4 target/arm: Default handling of BTYPE during translation 1c6561c9a8 target/arm: Cache the GP bit for a page in MemTxAttrs 9ee071294c exec: Add target-specific tlb bits to MemTxAttrs 79116bebaa target/arm: Add BT and BTYPE to tb->flags 6fd0b311a5 target/arm: Add PSTATE.BTYPE 59b3d084bc target/arm: Introduce isar_feature_aa64_bti === OUTPUT BEGIN === 1/12 Checking commit 59b3d084bc01 (target/arm: Introduce isar_feature_aa64_bti) 2/12 Checking commit 6fd0b311a5a6 (target/arm: Add PSTATE.BTYPE) 3/12 Checking commit 79116bebaace (target/arm: Add BT and BTYPE to tb->flags) 4/12 Checking commit 9ee071294c1b (exec: Add target-specific tlb bits to MemTxAttrs) ERROR: spaces prohibited around that ':' (ctx:WxW) #28: FILE: include/exec/memattrs.h:47: + unsigned int target_tlb_bit0 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #29: FILE: include/exec/memattrs.h:48: + unsigned int target_tlb_bit1 : 1; ^ ERROR: spaces prohibited around that ':' (ctx:WxW) #30: FILE: include/exec/memattrs.h:49: + unsigned int target_tlb_bit2 : 1; ^ total: 3 errors, 0 warnings, 16 lines checked Patch 4/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 5/12 Checking commit 1c6561c9a819 (target/arm: Cache the GP bit for a page in MemTxAttrs) 6/12 Checking commit 57cafb41c482 (target/arm: Default handling of BTYPE during translation) WARNING: Block comments use a leading /* on a separate line #70: FILE: target/arm/translate-a64.c:13730: +/** ERROR: return is not a function, parentheses are not required #97: FILE: target/arm/translate-a64.c:13757: + return (tlb_hit(entry->addr_code, addr) && WARNING: Block comments use a leading /* on a separate line #102: FILE: target/arm/translate-a64.c:13762: +/** total: 1 errors, 2 warnings, 196 lines checked Patch 6/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 7/12 Checking commit 905ade330525 (target/arm: Reset btype for direct branches) 8/12 Checking commit b3fbe9ad27be (target/arm: Set btype for indirect branches) 9/12 Checking commit 1a387cb4b4bf (target/arm: Add x-guarded-pages cpu property for user-only) 10/12 Checking commit ba139e01449c (target/arm: Enable BTI for -cpu max) 11/12 Checking commit d5315467cf35 (linux-user/aarch64: Reset btype for syscalls and signals) 12/12 Checking commit 18c0b24bcd26 (tests/tcg/aarch64: Add bti smoke test) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #32: new file mode 100644 ERROR: externs should be avoided in .c files #116: FILE: tests/tcg/aarch64/bti-crt.inc.c:13: +int main(void); total: 1 errors, 1 warnings, 128 lines checked Patch 12/12 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/20190128223118.5255-1-richard.hender...@linaro.org/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com