Patchew URL: https://patchew.org/QEMU/1548410831-19553-1-git-send-email-pbonz...@redhat.com/
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1548410831-19553-1-git-send-email-pbonz...@redhat.com Subject: [Qemu-devel] [RFC PATCH v5 00/52] Support Kconfig in QEMU === TEST SCRIPT BEGIN === #!/bin/bash git config --local diff.renamelimit 0 git config --local diff.renames True git config --local diff.algorithm histogram ./scripts/checkpatch.pl --mailback base.. === TEST SCRIPT END === Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384 From https://github.com/patchew-project/qemu - [tag update] patchew/1548410831-19553-1-git-send-email-pbonz...@redhat.com -> patchew/1548410831-19553-1-git-send-email-pbonz...@redhat.com Switched to a new branch 'test' 12539e4 kconfig: introduce CONFIG_TEST_DEVICES 2fadac6 i386-softmmu.mak: remove all CONFIG_* except boards definitions 8c1fb84 isa: express SuperIO dependencies with Kconfig 8e31743 tpm: express dependencies with Kconfig 7ffb3fa virtio: express virtio dependencies with Kconfig 5a72a0c vfio: express vfio dependencies with Kconfig a597633 hyperv: express dependencies with kconfig 1ef5cc5 display: express dependencies with kconfig fdd2c12 ptimer: express dependencies with Kconfig fdf78be i2c: express dependencies with Kconfig 9b93766 i386: express dependencies with Kconfig 5836083 isa: express dependencies with kconfig 7a26eaa scsi: express dependencies with Kconfig 74950a8 build: convert usb.mak to Kconfig 069934d build: convert sound.mak to Kconfig 5d18627 build: convert pci.mak to Kconfig f08f56a hw/pci/Makefile.objs: make pcie configurable f4642a7 ide: express dependencies with Kconfig 5a452a1 minikconf: implement allnoconfig and defconfig 8aa7369 build: switch to Kconfig 26b1ac2 kconfig: introduce kconfig files c4119d6 hw/display: make edid configurable 9a6e436 minikconfig: add semantic analysis afcf405 minikconfig: add AST 2f64711 minikconfig: add parser skeleton 18ac9b6 hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI 5e30d1f hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller 8254b1b hw/tricore/Makefile.objs: Create CONFIG_* for tricore 150eb60 hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc b1fe096 hw/moxie/Makefile.objs: Conditionally build moxie baf0d86 hw/hppa/Makefile.objs: Create CONFIG_* for hppa 13aa027 hw/cris/Makefile.objs: Create CONFIG_* for cris 1098821 hw/alpha/Makefile.objs: Create CONFIG_* for alpha aa55c75 hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64 3d4876a hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards c2ce7cf hw/nios2/Makefile.objs: Conditionally build nios2 60bf62c hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally 6a9dfa0 hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst e341e43 hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created c02d4cd hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices d90d4f8 hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device aa9c376 hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_* 4feddc1 hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards d681b51 hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards 8a86443 hw/m68k/Makefile.objs: Conditionally build boards 9321f38 hw/arm/Makefile.objs: CONFIG_VIRT created for virt board 67293f7 hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards a2f1b83 build: actually use CONFIG_PAM 48ca0b0 hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS f9385af vfio: move conditional up to hw/Makefile.objs 3c1f0c4 ide: split ioport registration to a separate file de15bc2 arm: disable CONFIG_SERIAL_ISA === OUTPUT BEGIN === 1/52 Checking commit de15bc290e9c (arm: disable CONFIG_SERIAL_ISA) 2/52 Checking commit 3c1f0c425e86 (ide: split ioport registration to a separate file) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #71: new file mode 100644 WARNING: Block comments use a leading /* on a separate line #132: FILE: hw/ide/ioport.c:57: + /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA WARNING: Block comments use * on subsequent lines #133: FILE: hw/ide/ioport.c:58: + /* ??? Assume only ISA and PCI configurations, and that the PCI-ISA + bridge has been setup properly to always register with ISA. */ WARNING: Block comments use a trailing */ on a separate line #133: FILE: hw/ide/ioport.c:58: + bridge has been setup properly to always register with ISA. */ total: 0 errors, 4 warnings, 113 lines checked Patch 2/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 3/52 Checking commit f9385aff8c74 (vfio: move conditional up to hw/Makefile.objs) 4/52 Checking commit 48ca0b0bb040 (hw/pci-host/Makefile.objs: make CONFIGS clear for PCI EXPRESS) 5/52 Checking commit a2f1b8382880 (build: actually use CONFIG_PAM) 6/52 Checking commit 67293f7ac014 (hw/i386/Makefile.objs: Build pc_piix* and pc_q35 boards) 7/52 Checking commit 9321f38d4c1c (hw/arm/Makefile.objs: CONFIG_VIRT created for virt board) 8/52 Checking commit 8a86443748e8 (hw/m68k/Makefile.objs: Conditionally build boards) 9/52 Checking commit d681b512df03 (hw/microblaze/Makefile.objs: Create configs for petalogix and xilinx boards) 10/52 Checking commit 4feddc17c458 (hw/mips/Makefile.objs: Create CONFIG_* for r4k, malta, mipssim boards) 11/52 Checking commit aa9c37673515 (hw/ppc/Makefile.objs: Build all boards conditinally with CONFIG_*) 12/52 Checking commit d90d4f8bb07b (hw/sh4/Makefile.objs: New CONFIG_* varibales created for sh4 boards and device) 13/52 Checking commit c02d4cdf59cc (hw/s390/Makefile.objs: Create new CONFIG_* variables for s390x boards and devices) 14/52 Checking commit e341e43ea749 (hw/sparc/Makefile.objs: CONFIG_* for sun4m and leon3 created) 15/52 Checking commit 6a9dfa037fad (hw/lm32/Makefile.objs: Conditionally build lm32 and milkmyst) 16/52 Checking commit 60bf62c31c54 (hw/xtensa/Makefile.objs: Build xtensa_sim and xtensa_fpga conditionally) 17/52 Checking commit c2ce7cf4611e (hw/nios2/Makefile.objs: Conditionally build nios2) 18/52 Checking commit 3d4876ad59dc (hw/riscv/Makefile.objs: Create CONFIG_* for riscv boards) 19/52 Checking commit aa55c758c409 (hw/sparc64/Makefile.objs: Create CONFIG_* for sparc64) 20/52 Checking commit 1098821e3116 (hw/alpha/Makefile.objs: Create CONFIG_* for alpha) 21/52 Checking commit 13aa0274be57 (hw/cris/Makefile.objs: Create CONFIG_* for cris) 22/52 Checking commit baf0d866cbf9 (hw/hppa/Makefile.objs: Create CONFIG_* for hppa) 23/52 Checking commit b1fe09618bfe (hw/moxie/Makefile.objs: Conditionally build moxie) 24/52 Checking commit 150eb6021400 (hw/openrisc/Makefile.objs: Create CONFIG_* for openrisc) 25/52 Checking commit 8254b1b5e1aa (hw/tricore/Makefile.objs: Create CONFIG_* for tricore) 26/52 Checking commit 5e30d1f03e84 (hw/i2c/Makefile.objs: Create new CONFIG_* variables for EEPROM and ACPI controller) 27/52 Checking commit 18ac9b68146f (hw/vfio/Makefile.objs: Create new CONFIG_* variables for VFIO core and PCI) 28/52 Checking commit 2f64711b7cbc (minikconfig: add parser skeleton) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #35: new file mode 100644 WARNING: line over 80 characters #251: FILE: scripts/minikconf.py:212: + 'Expected identifier starting with "CONFIG_"', TOK_NONE) WARNING: line over 80 characters #344: FILE: scripts/minikconf.py:305: + raise KconfigParserError(self, 'expected "source", "config", identifier, ' WARNING: line over 80 characters #370: FILE: scripts/minikconf.py:331: + raise KconfigParserError(self, 'expected "source", "config" or identifier') ERROR: line over 90 characters #395: FILE: scripts/minikconf.py:356: + if self.src[self.cursor + length].isalnum() or self.src[self.cursor + length] == '|': WARNING: line over 80 characters #448: FILE: scripts/minikconf.py:409: + while self.src[self.cursor].isalnum() or self.src[self.cursor] == '_': total: 1 errors, 5 warnings, 425 lines checked Patch 28/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 29/52 Checking commit afcf405ac260 (minikconfig: add AST) WARNING: line over 80 characters #89: FILE: scripts/minikconf.py:86: + return "config %s default %s if %s" % (self.dest, value, self.cond) total: 0 errors, 1 warnings, 170 lines checked Patch 29/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 30/52 Checking commit 9a6e43617ce7 (minikconfig: add semantic analysis) WARNING: line over 80 characters #112: FILE: scripts/minikconf.py:102: + raise Exception('contradiction between clauses when setting %s' % self) WARNING: line over 80 characters #215: FILE: scripts/minikconf.py:214: + debug_print(i, "->", [str(x) for x in self.referenced_vars[i].outgoing]) total: 0 errors, 2 warnings, 223 lines checked Patch 30/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 31/52 Checking commit c4119d6e81ce (hw/display: make edid configurable) 32/52 Checking commit 26b1ac2c0b73 (kconfig: introduce kconfig files) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #44: new file mode 100644 WARNING: line over 80 characters #1762: FILE: scripts/minikconf.py:636: + print ("%s: at least one argument is required" % argv[0], file=sys.stderr) total: 0 errors, 2 warnings, 1363 lines checked Patch 32/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 33/52 Checking commit 8aa73695da7a (build: switch to Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #481: deleted file mode 100644 total: 0 errors, 1 warnings, 325 lines checked Patch 33/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 34/52 Checking commit 5a452a1fc119 (minikconf: implement allnoconfig and defconfig) 35/52 Checking commit f4642a7c62b2 (ide: express dependencies with Kconfig) 36/52 Checking commit f08f56a670ae (hw/pci/Makefile.objs: make pcie configurable) 37/52 Checking commit 5d186272f909 (build: convert pci.mak to Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #120: deleted file mode 100644 total: 0 errors, 1 warnings, 472 lines checked Patch 37/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 38/52 Checking commit 069934d3cb35 (build: convert sound.mak to Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #70: deleted file mode 100644 total: 0 errors, 1 warnings, 51 lines checked Patch 38/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 39/52 Checking commit 74950a85f9f2 (build: convert usb.mak to Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #158: deleted file mode 100644 total: 0 errors, 1 warnings, 157 lines checked Patch 39/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 40/52 Checking commit 7a26eaae9594 (scsi: express dependencies with Kconfig) 41/52 Checking commit 583608364d1c (isa: express dependencies with kconfig) 42/52 Checking commit 9b937662f4e1 (i386: express dependencies with Kconfig) 43/52 Checking commit fdf78be1f429 (i2c: express dependencies with Kconfig) 44/52 Checking commit fdd2c128b788 (ptimer: express dependencies with Kconfig) 45/52 Checking commit 1ef5cc5fb73b (display: express dependencies with kconfig) 46/52 Checking commit a59763338008 (hyperv: express dependencies with kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #17: deleted file mode 100644 total: 0 errors, 1 warnings, 15 lines checked Patch 46/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 47/52 Checking commit 5a72a0c385fc (vfio: express vfio dependencies with Kconfig) 48/52 Checking commit 7ffb3fa21b40 (virtio: express virtio dependencies with Kconfig) WARNING: added, moved or deleted file(s), does MAINTAINERS need updating? #37: deleted file mode 100644 total: 0 errors, 1 warnings, 109 lines checked Patch 48/52 has style problems, please review. If any of these errors are false positives report them to the maintainer, see CHECKPATCH in MAINTAINERS. 49/52 Checking commit 8e3174384e2b (tpm: express dependencies with Kconfig) 50/52 Checking commit 8c1fb84ff49b (isa: express SuperIO dependencies with Kconfig) 51/52 Checking commit 2fadac69d98b (i386-softmmu.mak: remove all CONFIG_* except boards definitions) 52/52 Checking commit 12539e489992 (kconfig: introduce CONFIG_TEST_DEVICES) === OUTPUT END === Test command exited with code: 1 The full log is available at http://patchew.org/logs/1548410831-19553-1-git-send-email-pbonz...@redhat.com/testing.checkpatch/?type=message. --- Email generated automatically by Patchew [http://patchew.org/]. Please send your feedback to patchew-de...@redhat.com
