On 2/1/19 1:29 PM, Max Reitz wrote: > Before this patch, bdrv_refresh_filename() is used in a pushing manner: > Whenever the BDS graph is modified, the parents of the modified edges > are supposed to be updated (recursively upwards). However, that is > nonviable, considering that we want child changes not to concern > parents. > > Also, in the long run we want a pull model anyway: Here, we would have a > bdrv_filename() function which returns a BDS's filename, freshly > constructed. > > This patch is an intermediate step. It adds bdrv_refresh_filename() > calls before every place a BDS.filename value is used. The only > exceptions are protocol drivers that use their own filename, which > clearly would not profit from refreshing that filename before. > > Also, bdrv_get_encrypted_filename() is removed along the way (as a user > of BDS.filename), since it is completely unused. > > In turn, all of the calls to bdrv_refresh_filename() before this patch > are removed, because we no longer have to call this function on graph > changes. > > Signed-off-by: Max Reitz <mre...@redhat.com> > ---
Reviewed-by: Eric Blake <ebl...@redhat.com> -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature
