On 2/4/19 3:56 PM, Eric Blake wrote: > Flag commit attribution tags that are unusual (often because they > were a typo), but only as a warning (because sometimes a humorous > or otherwise useful tag is intentionally supplied). > > This picks the 6-most popular tags, each with 700 or more uses (well, > S-o-b was already checked for case-sensitivity and typos, leaving > only 5 new tags being checked), as determined by: > $ git log | sed -n 's/^ *\([A-Za-z-]*-by:\).*/\1/p' | \ > sort | uniq -c | sort -k1,1n | tail > > Most of the rejected lines were obvious typos (among others, we've > had 4 cases of someone being burnt, based on Singed-off-by; and 2 > cases of list-reading via an e-reader, based on eviewed-by; there > are also lines forgetting a space after the ':') or otherwise > tongue-in-check (3 Approximately-suggested-by). A few lines not > whitelisted here may be legitimate, but as they are orders of > magnitude rarer, it is therefore not worth worrying about > (7 Requested-by, 3 Co-authored-by, 1 Inspired-by, etc.). > > Signed-off-by: Eric Blake <ebl...@redhat.com> > ---
> } > + } elsif($line =~ /^\s*([A-Za-z-])*-by:/ && > + ($1 !~ /(Suggest|Report|Test|Ack|Review)ed/ || > + $line !~ /^\s[a-z-]*-by:\S/i)) { Oops, that last one is supposed to be =~, to flag lines that forget the space between *-by: and the email address. -- Eric Blake, Principal Software Engineer Red Hat, Inc. +1-919-301-3226 Virtualization: qemu.org | libvirt.org
signature.asc
Description: OpenPGP digital signature